Demonology ST/AoE Gs-E Macro 7.0.3

Hey, this is my first selfmade macro for Demolock. Because i dont like the ones available for the moment i decided to write my own. This macro is based on the 7.0.3 demo guid on icy-veins (It is not perfect for ppl with t18/4 and archi-trinket cause it contains dreadstalker, when i get my t18 full and my trinket i will write an updated version ). With my 712 ilvl wl with 1 t-set boni i can get aroun 55-70k single target dmg on puppet and 80k+ on Aoe puppets. i hope you like my macro and pls give me some feedback what i could change or update ( sry for my bad english )

talents are in the macro description!

Sequences['Demosingletest'] = {
StepFunction = [[
		stepa = "12345"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
]],
author='Seydon',
specID=266,
helpTxt = 'Talents: 1111222',
icon='Spell_Warlock_Demonbolt',
PreMacro=[[
/cast [nopet,group] Summon Felguard
/cast [nopet,nogroup] Summon Felguard
/targetenemy [noharm][dead]
/petattack [@target,harm]
]],
-- Macro 1
	[[
/castsequence [combat] Call Dreadstalkers, Demonic Empowerment, Demonbolt
	]], 

-- Macro 2
	[[
/castsequence [combat] Summon Doomguard, Demonic Empowerment, Demonbolt
	]],

-- Macro 3
	[[
/castsequence [combat] Grimoire: Felguard, Demonic Empowerment, Demonbolt
	]],

-- Macro 4
	[[
/castsequence [nochanneling] Doom, Demonbolt, Demonbolt, Demonbolt, Hand of Gul'dan, Demonic Empowerment, Life Tap
	]],

-- Macro 5
	[[
/cast [combat] Command Demon
	]],
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

Sequences['Demoaoetest'] = {
StepFunction = [[
		stepa = "12345"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
]],
author='Seydon',
specID=266,
helpTxt = 'Talents: 1111222',
icon="Spell_Warlock_Hand_of_Gul'dan",
PreMacro=[[
/cast [nopet,group] Summon Felguard
/cast [nopet,nogroup] Summon Felguard
/targetenemy [noharm][dead]
/petattack [@target,harm]
]],
-- Macro 1
	[[
/castsequence [combat] Call Dreadstalkers, Demonic Empowerment, Demonwrath
	]], 

-- Macro 2
	[[
/castsequence [combat] Summon Infernal, Demonic Empowerment, Demonwrath
	]],

-- Macro 3
	[[
/castsequence [combat] Grimoire: Felguard, Demonic Empowerment, Demonwrath
	]],

-- Macro 4
	[[
/castsequence [nochanneling] Hand of Gul'dan, Demonic Empowerment, Demonwrath, Demonwrath, Demonwrath, Life Tap
	]],

-- Macro 5
	[[
/cast [combat] Command Demon
	]],
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

It’s good seems to be working fine, one this is you really don’t need two macros for ST and AoE, just have the doomguard and infernal on seperate keys.

well the reason i use 2 macros is Demonwrath i use this aoe macro on 5+ enemys for crazy aoe dmg ty for you feedback

Works great. Thank you.

Spell icon for AOE does not work

Also while in acutal combat / raid … locks up if you have no shards

I agree it locks up with no shards. Keeping Demonbolt on a separate key is a must. Otherwise works reasonably well.

ok i worked a bit and now i think it should work in any situation i used a step function but im new to this thanks for the feedback ^^

Sequences['Demosingletest'] = {
StepFunction = [[
		stepa = "12345"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
]],
author='Seydon',
specID=266,
helpTxt = 'Talents: 1111222',
icon='Spell_Warlock_Demonbolt',
PreMacro=[[
/cast [nopet,group] Summon Felguard
/cast [nopet,nogroup] Summon Felguard
/targetenemy [noharm][dead]
/petattack [@target,harm]
]],
-- Macro 1
	[[
/castsequence [combat] Call Dreadstalkers, Demonic Empowerment, Demonbolt
	]], 

-- Macro 2
	[[
/castsequence [combat] Summon Doomguard, Demonic Empowerment, Demonbolt
	]],

-- Macro 3
	[[
/castsequence [combat] Grimoire: Felguard, Demonic Empowerment, Demonbolt
	]],

-- Macro 4
	[[
/castsequence [nochanneling] Doom, Demonbolt, Demonbolt, Demonbolt, Hand of Gul'dan, Demonic Empowerment, Life Tap
	]],

-- Macro 5
	[[
/cast [combat] Command Demon
	]],
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

Sequences['Demoaoetest'] = {
StepFunction = [[
		stepa = "12345"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
]],
author='Seydon',
specID=266,
helpTxt = 'Talents: 1111222',
icon='Spell_Warlock_Hand_of_Gul'dan',
PreMacro=[[
/cast [nopet,group] Summon Felguard
/cast [nopet,nogroup] Summon Felguard
/targetenemy [noharm][dead]
/petattack [@target,harm]
]],
-- Macro 1
	[[
/castsequence [combat] Call Dreadstalkers, Demonic Empowerment, Demonwrath
	]], 

-- Macro 2
	[[
/castsequence [combat] Summon Infernal, Demonic Empowerment, Demonwrath
	]],

-- Macro 3
	[[
/castsequence [combat] Grimoire: Felguard, Demonic Empowerment, Demonwrath
	]],

-- Macro 4
	[[
/castsequence [nochanneling] Hand of Gul'dan, Demonic Empowerment, Demonwrath, Demonwrath, Demonwrath, Life Tap
	]],

-- Macro 5
	[[
/cast [combat] Command Demon
	]],
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

Icon still does not work due to 3 ’ and coding doesn’t allow it, might want to change it to the icon= (id number 105174) might be able to test it after that.

or posible change warlock_handofguldan ill be testing both of these see if i can get the icon to work.

its a problem on this line

icon=‘Spell_Warlock_Hand_of_Gul’dan’,

change it to

icon=“Spell_Warlock_Hand_of_Gul’dan”,

it is icon=‘ability_warlock_handofguldan’,

not Hand_of_Gul’dan