my 1st attempt at a macro this big version 4

As the title states this is my first ever attempt at a macro of this style, i am currently 849 ilvl on live servers as of patch 7.1, and i do around 200k on a dummy with this but only 130k is in raids or dungeons any help would be nice

Fist things first i would put it in the code box but dont know how secondly i think there is something wrong with this macro so if anyone works it out please can you tell me how to fix this

Sequences[‘Demonsoupv4’] = {
author=“Feardotkill@Kazzak”,
specID=266,
version=21,
source = “Local”,
helpTxt = “Talents: 3211121”,
icon=‘INV_MISC_QUESTIONMARK’,
lang=“enUS”,
PreMacro=[[
/petattack [exists]
]],
“/castsequence [nochanneling] reset=target Doom”,
“/castsequence [combat,nochanneling] !Call Dreadstalkers, Demonic Empowerment”,
“/castsequence [combat,nochanneling] !Grimoire: Felguard, Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast [combat] Command Demon”,
“/cast Shadow Bolt”,
“/cast [combat] Summon Doomguard”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonwrath”,
“/cast Thal’kiel’s Consumption”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Life Tap”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast [combat] Command Demon”,
“/cast Thal’kiel’s Consumption”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast [combat] Summon Doomguard”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Call Dreadstalkers”,
“/cast [combat] Command Demon”,
“/cast Demonic Empowerment”,
“/cast Thal’kiel’s Consumption”,
“/cast Shadow Bolt”,
“/cast Demonwrath”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

Whoa that’s a big un!

Ok, right, 1st thing that jumps out obviously is you have repeats of the same spells/abilities. 2nd is there is way way too many /cast which means how this macro performs is going to be extremely dependent on how often/fast you press the macro button.

Couple of simple things i have found making my macro’s:

Ideally you want your core DPS rotation inside a castsequence line, making sure to only place DPS spells that do NOT have long cooldowns or require Soul Shards otherwise the macro can “lock” when there is nothing to spend or is waiting on a long CD.

Use a separate castsequence or cast line to deal with long CD’s (if you want them in the macro and not manually triggered) and Soul Shard spenders, taking care not to place too many in 1 line.

Use only things you want to fire off in order in a castsequence, anything that you want to use all the time/on cooldown you can keep as a /cast.

The way castsequence works is that line will execute spells in order, when stuff is on Cooldown or insufficient Soul Shards it’ll be using /cast or trying separate castsequence lines depending what else is in the macro.

As it’s pretty confusing and you may not get what i am saying i’m gonna post an untested, but tidied up version of your macro to attempt to illustrate what i am saying:

Sequences[‘Demonsoupv4′] = {
author=”Feardotkill@Kazzak”,
specID=266,
version=21,
source = “Local”,
helpTxt = “Talents: 3211121″,
icon=’INV_MISC_QUESTIONMARK’,
lang=”enUS”,
PreMacro=[[
/targetenemy [noharm][dead]
/petattack [exists]
]],
“/castsequence [nochanneling] reset=target Doom”,
“/castsequence [combat][nochanneling] reset=target Call Dreadstalkers, Demonic Empowerment, Grimoire: Felguard, Demonic Empowerment”,
“/castsequence [nochanneling] reset=combat Shadow Bolt, Shadow Bolt, Shadow Bolt, Life Tap",
'/cast [combat] Summon Doomguard',
“/cast Hand of Gul’dan”,
'/cast Summon Darkglare',
'/cast Demonwrath',
"/cast Thal’kiel’s Consumption”,
'/cast [combat] Command Demon',
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

OK, please note i have not played Demonology spec at 110, i am purely basing this off what i saw in your macro. Anything that was repeated multiple times i have tried to incorporate into a castsequence for you that won’t lock. The spells left as /cast may fire too often or not at optimal times, so you might want to place some or all of them into either a current /castsequence line or into another new one, i simply do not know enough about the spec to make that call.

I added a /targetenemy [noharm][dead] to the pre-macro, this means that if you do not have an ememy targeted then it’ll automatically target an enemy that is in your frontal arc, this may not be what you want, so remove the line if you wish to manually target as it can sometimes end with mistaken pulls if you are mashing the macro just as something dies.

Hope this helps

What issues are you having with it?

just does not seem to be consistent dps i know warlocks have next to 0 movement ability to cast and move on mrrobot.com it saying i should be doing 242k+ with my current gear and im doing 130+ thats a huge diffrence

kytie thanks for the feed back but the macro you posted does not work its constantly spamming doom and only casts 1 shadow bolt then hand of guldan

Nothing really wrong with the longer macros. It mirrors the ones I use and the /cast is intentional as it was rotation based which is set to be cast slow around 1800ms+ depending on cast time modified by haste.

Demonology is not proc based and has long cast times (2 seconds default)

It’s set in a way it will never lock up and give good shard generation that you want to use for your dreadstalkers and hand of gul’dans, some of the repeats are there for building up your empowerment buffs for thal’kiel’s consumptions.

It’s an intentiony long build for a 4 minute fight.

The only issue I see with its current make up is there are 1 to 2 too many shadow bolts and 1 to 2 demonic empowerment missing as you have a lot of summons with no empowerment. You want to empower after around 2 summons / hands to maintain it. Also I wouldn’t put the first Doom on a castsequence but instead a cast so its not used so much until your hands fire off (if using hand of doom).

Targetenemy also shouldn’t be used if you have petattack as you will need to be real quick to bring the felguard back to you or you will pull packs due to felguard using intercept. If you want to keep the felguard in the pack instead of coming back to you after each kill then put him on defensive mode after he starts attacking then passive until you attack another pack.

Lastly, try to keep your spenders and timers off of a castsequence as you run the risk of locking up until the resource becomes available again.

yeah, i was just posting it as an idea for a tidied up version, was not expecting it to be optimal by any means, as i said i don’t play Demonology spec and my lock is only 51 atm and Affliction, was just trying to give you some pointers about how you can achieve a much more compact macro with hopefully more DPS.

I’ll amend it below to hopefully get it more in line with what i think you want:

Sequences[‘Demonsoupv4′] = {
author=”Feardotkill@Kazzak”,
specID=266,
version=21,
source = “Local”,
helpTxt = “Talents: 3211121″,
icon=’INV_MISC_QUESTIONMARK’,
lang=”enUS”,
PreMacro=[[
/targetenemy [noharm][dead]
/petattack [exists]
]],
“/castsequence [combat][nochanneling] reset=target Doom, Call Dreadstalkers, Demonic Empowerment, Hand of Gul’dan, Demonic Empowerment”,
“/castsequence [combat][nochanneling] Grimoire: Felguard, Demonic Empowerment",
“/castsequence [nochanneling] reset=combat Shadow Bolt, Shadow Bolt Shadow Bolt, Life Tap",
'/cast Summon Darkglare',
'/cast Demonwrath',
"/cast Thal’kiel’s Consumption”,
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

Ok, now it should cast Doom pretty much once per target and be more reliable with the rotation, according to icey veins there’s a couple of abilities that are still in the macro which work best when you have a decent number of AE targets, so you may want to consider having a main macro for single target/low enemy count with a separate AE one that has the higher impact AE stuff only, so you can better coordinate your spike AE DPS and not potentially waste cooldowns on sub-optimal fights and subsequently not have them up when you can really cash in.

Your macro is not importing to GS-E Kytie.

[quote quote=35949]Your macro is not importing to GS-E Kytie.
[/quote]What do you mean not importing?
I just copy/paste into the class specific file in gs-mymacros/macros folder, after that it either works or doesn’t work lol. Personally i do not use GSSE in game except to sometimes check if any changes i have written have been updated after a /reloadui…I do everything in Notepad++

I raid with this & only DH out do me:

---Demo Lock---
---2231122---
Sequences["Demon1"] = {
StepFunction = [[
        limit = limit or 1
        if step == limit then
            limit = limit % #macros + 1
            step = 1
        else
            step = step % #macros + 1
        end
]],
PreMacro=[[
/petautocastoff [group] Threatening Presence
/petautocaston [nogroup] Threatening Presence
/petattack [@target,harm]
/targetenemy [noharm][dead]reset=target
]],
[[/castsequence [combat,nochanneling] !Call Dreadstalkers, Demonic Empowerment]],
[[/castsequence [combat,nochanneling] !Grimoire: Felguard, Demonic Empowerment]],
[[/castsequence [combat,nochanneling] Demonbolt, Demonbolt, Demonbolt, Demonbolt, Hand of Gul'dan, Demonic Empowerment, Life Tap]],
[[/cast [combat,nochanneling] !Thal'kiel's Consumption]],
[[/castsequence [combat,nochanneling] !Command Demon, Demonwrath]],
PostMacro=[[
/use 13
/use 14
]],

Druccy i would like to try your macro above but it doesnt seem to work, im using GSE, any suggestions?

Converted to GSE (I think/hope it works)

Sequences["Demon1"] = {
author='Druccy',
specID=266,
helpTxt = "ST - 3211222 ",
icon="Spell_Warlock_HandofGul'dan",
StepFunction = GSStaticPriority,
PreMacro=[[
/petautocastoff [group] Threatening Presence
/petautocaston [nogroup] Threatening Presence
/petattack [@target,harm]
/targetenemy [noharm][dead]
]],
"/castsequence [combat,nochanneling] Call Dreadstalkers, Demonic Empowerment",
"/castsequence [combat,nochanneling] Grimoire: Felguard, Demonic Empowerment",
"/castsequence [combat,nochanneling] Demonbolt, Demonbolt, Demonbolt",
"/castsequence [combat,nochanneling] !Hand of Gul'dan, Demonic Empowerment, Life Tap",
"/cast [combat,nochanneling] Thal'kiel's Consumption",
"/castsequence [combat] Command Demon, Demonwrath, Drain Life",
PostMacro=[[
]],
}

Awesome thanks will try it out!

Hey Guys - did the update for it on OP - I do not use GS-E as I keep getting errors so just gave up on it but yes please do convert it if you use GS-E.

Hi Druccy

What have u set u AHK, delay/sleep??

`Sequences[”Demon1”] = {
author=’Druccy’,
specID=266,
helpTxt = ”ST – 3211222 ”,
icon=”Spell_Warlock_HandofGul’dan”,
StepFunction = GSStaticPriority,
PreMacro=[[
/petautocastoff [group] Threatening Presence
/petautocaston [nogroup] Threatening Presence
/petattack [@target,harm]
/targetenemy [noharm][dead]reset=target
]],
”castsequence [nochanneling] !Call Dreadstalkers, Demonic Empowerment”,
”castsequence [nochanneling] !Grimoire: Felguard, Demonic Empowerment”,
”castsequence [nochanneling] Demonbolt, Demonbolt, Demonbolt, Demonbolt, Hand of Gul’dan, Demonic Empowerment, Life Tap”,
”cast [nochanneling] Thal’kiel’s Consumption”,
”castsequence [nochanneling] Command Demon, Demonwrath”,
PostMacro=[[
]],

Sequences[”Demon1”] = {
author=’Druccy’,
specID=266,
helpTxt = ”ST – 3211222 ”,
icon=”Spell_Warlock_HandofGul’dan”,
StepFunction = GSStaticPriority,
PreMacro=[[
/petautocastoff [group] Threatening Presence
/petautocaston [nogroup] Threatening Presence
/petattack [@target,harm]
/targetenemy [noharm][dead]reset=target
]],
”castsequence [nochanneling] !Call Dreadstalkers, Demonic Empowerment”,
”castsequence [nochanneling] !Grimoire: Felguard, Demonic Empowerment”,
”castsequence [nochanneling] Demonbolt, Demonbolt, Demonbolt, Demonbolt, Hand of Gul’dan, Demonic Empowerment, Life Tap”,
”cast [nochanneling] Thal’kiel’s Consumption”,
”castsequence [nochanneling] Command Demon, Demonwrath”,
PostMacro=[[
]],

Sequences[‘Demonsoupv4′] = {
author=”Feardotkill@Kazzak”,
specID=266,
version=21,
source = “Local”,
helpTxt = “Talents: 3211121″,
icon=’INV_MISC_QUESTIONMARK’,
lang=”enUS”,
PreMacro=[[
/petattack [exists]
]],
“/castsequence [nochanneling] reset=target Doom”,
“/castsequence [combat,nochanneling] !Call Dreadstalkers, Demonic Empowerment”,
“/castsequence [combat,nochanneling] !Grimoire: Felguard, Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast [combat] Command Demon”,
“/cast Shadow Bolt”,
“/cast [combat] Summon Doomguard”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonwrath”,
“/cast Thal’kiel’s Consumption”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Life Tap”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast [combat] Command Demon”,
“/cast Thal’kiel’s Consumption”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast [combat] Summon Doomguard”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Call Dreadstalkers”,
“/cast [combat] Command Demon”,
“/cast Demonic Empowerment”,
“/cast Thal’kiel’s Consumption”,
“/cast Shadow Bolt”,
“/cast Demonwrath”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonic Empowerment”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Hand of Gul’dan”,
“/cast Summon Darkglare”,
“/cast Call Dreadstalkers”,
“/cast Demonic Empowerment”,
“/cast Demonic Empowerment”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
“/cast Demonwrath”,
“/cast Demonic Empowerment”,
“/cast Life Tap”,
“/cast Shadow Bolt”,
“/cast Shadow Bolt”,
PostMacro=[[
/use [combat]13
/use [combat]14
]],
}

Hi Thomas - I use murgee.com - Auto keyboard & have it set to 90ms.

[quote quote=36377]Hi Thomas – I use murgee.com – Auto keyboard & have it set to 90ms.
[/quote]
I’ve had better DPS output with your macro so far. What so you have your Number of keys automated set as? The default (10)?