Pala Prot 7.0.2 single target and AOE 2 button masher

Hello made this but for the life of me I cannot get Blinding Light to cast on the aoe? ANy advice?

Talents are 233332 I’m lvl 92

Sequences[‘Protsingle’] = {
StepFunction = [[
limit = limit or 1
if step == limit then
limit = limit % #macros + 1
step = 1
else
step = step % #macros + 1
end
]],
PreMacro = [[
/targetenemy [noharm][dead]
]],
“/cast Avenger’s Shield”,
‘/cast Blessed Hammer’,
‘/cast Consecration’,
‘/cast Shield of the Righteous’,
‘/cast Judgment’,
‘/castsequence reset=6 Hammer of Justice’,
‘/castsequence reset=7 Consecration,Consecration’,
‘/cast [@player] Light of the Protector’,
PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/script UIErrorsFrame:Clear()
]],
}

Sequences[‘ProtAOE’] = {
StepFunction = [[
limit = limit or 1
if step == limit then
limit = limit % #macros + 1
step = 1
else
step = step % #macros + 1
end
]],
PreMacro = [[
/targetenemy [noharm][dead]
]],
“/cast Avenger’s Shield”,
‘/cast Consecration’,
‘/cast Blessed Hammer,Blessed Hammer’,
‘/castsequence reset=6 Blinding Light,Judgment’,
‘/cast Hammer of Justice’,
‘/castsequence reset=7 Consecration,Consecration’,
‘/cast Blessed Hammer,Blessed Hammer’,
‘/cast [@player] Light of the Protector’,
PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/script UIErrorsFrame:Clear()
]],
}

Might i suggest moving it to the Post Macro.

Sequences[‘Protsingle’] = {
 StepFunction = [[
 limit = limit or 1
 if step == limit then
 limit = limit % #macros + 1
 step = 1
 else
 step = step % #macros + 1
 end
 ]],
 PreMacro = [[
 /targetenemy [noharm][dead]
 ]],
 “/cast Avenger’s Shield”,
 ‘/cast Blessed Hammer’,
 ‘/cast Consecration’,
 ‘/cast Shield of the Righteous’,
 ‘/cast Judgment’,
 ‘/castsequence reset=6 Hammer of Justice’,
 ‘/castsequence reset=7 Consecration,Consecration’,
 ‘/cast [@player] Light of the Protector’,
 PostMacro = [[
 /cast Shield of the Righteous
 /cast Avenger’s Shield
 /script UIErrorsFrame:Clear()
 ]],
 }
Sequences[‘ProtAOE’] = {
 StepFunction = [[
 limit = limit or 1
 if step == limit then
 limit = limit % #macros + 1
 step = 1
 else
 step = step % #macros + 1
 end
 ]],
 PreMacro = [[
 /targetenemy [noharm][dead]
 ]],
 “/cast Avenger’s Shield”,
 ‘/cast Consecration’,
 ‘/cast Blessed Hammer,Blessed Hammer’,
 ‘/castsequence reset=6 Judgement’,
 ‘/castsequence reset=90 Blinding Light’,
 ‘/cast Hammer of Justice’,
 ‘/castsequence reset=7 Consecration,Consecration’,
 ‘/cast Blessed Hammer,Blessed Hammer’,
 ‘/cast [@player] Light of the Protector’,
 PostMacro = [[
 /cast Shield of the Righteous
 /cast Avenger’s Shield
 /script UIErrorsFrame:Clear()
 ]],
 }

Try this, I put it in code, fixed a spelling error and put the correct reset timer on blinding light

this is still not working!!!

The reason why its not working I think is because you still have Hammer of Justice in the macro.

Blessed Hammer replaces Hammer of Justice.


Sequences[‘Protsingle’] = {
 StepFunction = [[
 limit = limit or 1
 if step == limit then
 limit = limit % #macros + 1
 step = 1
 else
 step = step % #macros + 1
 end
 ]],
 PreMacro = [[
 /targetenemy [noharm][dead]
 ]],
 “/cast Avenger’s Shield”,
 ‘/cast Blessed Hammer’,
 ‘/cast Consecration’,
 ‘/cast Shield of the Righteous’,
 ‘/cast Judgment’,
 ‘/castsequence reset=7 Consecration,Consecration’,
 ‘/cast [@player] Light of the Protector’,
 PostMacro = [[
 /cast Shield of the Righteous
 /cast Avenger’s Shield
 /script UIErrorsFrame:Clear()
 ]],
 }

I can get your single target to work but your aoe one isn’t doing anything

Sequences['ProtAOE'] = {
 StepFunction = [[
 limit = limit or 1
 if step == limit then
 limit = limit % #macros + 1
 step = 1
 else
 step = step % #macros + 1
 end
 ]],
 PreMacro = [[
 /targetenemy [noharm][dead]
 ]],
 "/cast Avenger’s Shield",
 '/cast Consecration',
 '/cast Blessed Hammer,Blessed Hammer',
 '/castsequence reset=6 Judgement',
 '/castsequence reset=90 Blinding Light',
 '/castsequence reset=7 Consecration,Consecration',
 '/cast Blessed Hammer,Blessed Hammer',
 '/cast [@player] Light of the Protector',
 PostMacro = [[
 /cast Shield of the Righteous
 /cast Avenger’s Shield
 /script UIErrorsFrame:Clear()
 ]],
 }

I have not tested this but it should work now

for me that aoe one is still not working if it is for anyone else let me know if you did anything to it

Ok, tested it, fully working, it was the Judgment spelling error, the below should work for you :slight_smile:

Sequences["ProtAOE"] = {
 StepFunction = [[
	limit = limit or 1
	if step == limit then
		limit = limit % #macros + 1
		step = 1
	else
		step = step % #macros + 1
	end
]],
 PreMacro = [[
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 0
/targetenemy [noharm][dead]
]],
 "/cast Avenger's Shield",
 '/cast Consecration',
 '/cast Blessed Hammer,Blessed Hammer',
 '/castsequence reset=6 Judgment',
 '/castsequence reset=90 Blinding Light',
 '/castsequence reset=7 Consecration,Consecration',
 '/cast Blessed Hammer,Blessed Hammer',
 '/cast [@player] Light of the Protector',
 PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/startattack
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 1
]],
}

[quote quote=29884]for me that aoe one is still not working if it is for anyone else let me know if you did anything to it

[/quote]

I still haven’t gotten a chance to test it, but try that AoE one he put together but remove the e from Judgement (the old British spelling, interesting history, but the globally accepted spelling nowadays on both sides of the pond is Judgment)

I too will test it, but realms are still down…

EDIT: Tested it, pasted in my above comment, fully working :slight_smile:

[quote quote=29945]


for me that aoe one is still not working if it is for anyone else let me know if you did anything to it

I still haven’t gotten a chance to test it, but try that AoE one he put together but remove the e from Judgement (the old British spelling, interesting history, but the globally accepted spelling nowadays on both sides of the pond is Judgment)

I too will test it, but realms are still down…

EDIT: Tested it, pasted in my above comment, fully working ?

[/quote]

Ugh I could have sworn there was an E in that in the spell book. Well at least we all got it working as a community. =)

Ok i actually just noticed on the single target that Avenger’s Shield isn’t going on when using the macro. It looks like it has something to do with the ’ in the spelling. The only way the single target one works for me now is if I just have it skip that spell. If i leave the 's in the spelling when I am using the single target macro its actually spamming the code in /say and this has never happened to me before. I have a ton of macros working so im stumped as to what is happening with these 2 here.

[quote quote=29948]

for me that aoe one is still not working if it is for anyone else let me know if you did anything to it

Ugh I could have sworn there was an E in that in the spell book. Well at least we all got it working as a community. =)

[/quote]

I don’t know if you saw my other comment, because I’ve always spelt it Judgement, and they’re BOTH correct :smiley: I guess the “judgement” traces back to the 18th century, and whether the US or the UK was using one spelling, the other was using the reverse, now both are correct, but Judgement will soon be considered archaic, the “standard” accepted on both sides of the pond is Judgment, which is why your spell check didn’t catch it :stuck_out_tongue:

[quote quote=29951]Ok i actually just noticed on the single target that Avenger’s Shield isn’t going on when using the macro. It looks like it has something to do with the ‘ in the spelling. The only way the single target one works for me now is if I just have it skip that spell. If i leave the ‘s in the spelling when I am using the single target macro its actually spamming the code in /say and this has never happened to me before. I have a ton of macros working so im stumped as to what is happening with these 2 here.

[/quote]

Avenger’s Shield needs double quotes, not single, I forget why, I think its something to do with it appearing more than once, or something to that affect. either way, here is mine, fully functional (and be careful with the ’ and ", because “smart quotes” and shit like that is wrong :wink: copy and paste just the ’ from a working macro to make sure your editor has it right :slight_smile:

Sequences["ProtST"] = {
 StepFunction = [[
	limit = limit or 1
	if step == limit then
		limit = limit % #macros + 1
		step = 1
	else
		step = step % #macros + 1
	end
]],
 PreMacro = [[
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 0
/targetenemy [noharm][dead]
]],
 "/cast Avenger's Shield",
 '/cast Blessed Hammer',
 '/cast Consecration',
 '/cast Shield of the Righteous',
 '/cast Judgment',
 '/castsequence reset=7 Consecration,Consecration',
 '/cast [@player] Light of the Protector',
 PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/startattack
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 1
]],
}

Just to be clear, here are both single/multi target macro’s I’m using based on the aforementioned (slightly different name for single, just because I’m CDO)

someone else mentioned something about it spamming the “say” chat, the way i fixed it, (don’t ask me why this fixed it, I’m a google script ninja, not a programmer) was by removing the spaces before the / in the post macro :slight_smile:

Cheers

-Orleck

Sequences["ProtST"] = {
 StepFunction = [[
	limit = limit or 1
	if step == limit then
		limit = limit % #macros + 1
		step = 1
	else
		step = step % #macros + 1
	end
]],
 PreMacro = [[
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 0
/targetenemy [noharm][dead]
]],
 "/cast Avenger's Shield",
 '/cast Blessed Hammer',
 '/cast Consecration',
 '/cast Shield of the Righteous',
 '/cast Judgment',
 '/castsequence reset=7 Consecration,Consecration',
 '/cast [@player] Light of the Protector',
 PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/startattack
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 1
]],
}

Sequences["ProtAOE"] = {
 StepFunction = [[
	limit = limit or 1
	if step == limit then
		limit = limit % #macros + 1
		step = 1
	else
		step = step % #macros + 1
	end
]],
 PreMacro = [[
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 0
/targetenemy [noharm][dead]
]],
 "/cast Avenger's Shield",
 '/cast Consecration',
 '/cast Blessed Hammer,Blessed Hammer',
 '/castsequence reset=6 Judgment',
 '/castsequence reset=90 Blinding Light',
 '/castsequence reset=7 Consecration,Consecration',
 '/cast Blessed Hammer,Blessed Hammer',
 '/cast [@player] Light of the Protector',
 PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/startattack
/script UIErrorsFrame:Hide();
/console Sound_EnableSFX 1
]],
}

WoW i have no idea why they are both working for me now but I will check later if all spells are finally going off but somehow I must have been doing something differently because I got them both to work. Thank you so much for all your help and I wish I could share what my problem was but I have yet to figure out why they weren’t working and then just started to.

[quote quote=29959]WoW i have no idea why they are both working for me now but I will check later if all spells are finally going off but somehow I must have been doing something differently because I got them both to work. Thank you so much for all your help and I wish I could share what my problem was but I have yet to figure out why they weren’t working and then just started to.

[/quote]

Outstanding, glad we could all get it solved, that’s what this whole forum is for though, right? :smiley:

Cheers

-Orleck

[quote quote=29851]```
Sequences[‘Protsingle’] = {
StepFunction = [[
limit = limit or 1
if step == limit then
limit = limit % #macros + 1
step = 1
else
step = step % #macros + 1
end
]],
PreMacro = [[
/targetenemy [noharm][dead]
]],
“/cast Avenger’s Shield”,
‘/cast Blessed Hammer’,
‘/cast Consecration’,
‘/cast Shield of the Righteous’,
‘/cast Judgment’,
‘/castsequence reset=6 Hammer of Justice’,
‘/castsequence reset=7 Consecration,Consecration’,
‘/cast [@player] Light of the Protector’,
PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/script UIErrorsFrame:Clear()
]],
}

Sequences[‘ProtAOE’] = {
StepFunction = [[
limit = limit or 1
if step == limit then
limit = limit % #macros + 1
step = 1
else
step = step % #macros + 1
end
]],
PreMacro = [[
/targetenemy [noharm][dead]
]],
“/cast Avenger’s Shield”,
‘/cast Consecration’,
‘/cast Blessed Hammer,Blessed Hammer’,
‘/castsequence reset=6 Judgement’,
‘/castsequence reset=90 Blinding Light’,
‘/cast Hammer of Justice’,
‘/castsequence reset=7 Consecration,Consecration’,
‘/cast Blessed Hammer,Blessed Hammer’,
‘/cast [@player] Light of the Protector’,
PostMacro = [[
/cast Shield of the Righteous
/cast Avenger’s Shield
/script UIErrorsFrame:Clear()
]],
}

Try this, I put it in code, fixed a spelling error and put the correct reset timer on blinding light

[/quote]

Just of my own curiosity, though it's been a while since I read the patch notes, but why is there a need for two separate macros for single/multi target? I thought they combined crusader strike and the other one to make it so you did aoe while consecrate was down. Is it because the AoE one casts Consecrate sooner int he steps, and is there some AoE proc that makes Blessed Hammer castable more often? 

just curious :)

Well done on the work done. It works a whole lot better for me now. I have a lot to learn. I was using old macros and trying to get them to work with new spells ect. I would change the smallest bit and bam nothing would work. Change it back and still doesn’t work lol.

Ah well I’m using this for now and I’m going to experiment with other peoples see what’s best.

[quote quote=29962]

Sequences[‘Protsingle’] = {
 StepFunction = [[
 limit = limit or 1
 if step == limit then
 limit = limit % #macros + 1
 step = 1
 else
 step = step % #macros + 1
 end
 ]],
 PreMacro = [[
 /targetenemy [noharm][dead]
 ]],
 “/cast Avenger’s Shield”,
 ‘/cast Blessed Hammer’,
 ‘/cast Consecration’,
 ‘/cast Shield of the Righteous’,
 ‘/cast Judgment’,
 ‘/castsequence reset=6 Hammer of Justice’,
 ‘/castsequence reset=7 Consecration,Consecration’,
 ‘/cast [@player] Light of the Protector’,
 PostMacro = [[
 /cast Shield of the Righteous
 /cast Avenger’s Shield
 /script UIErrorsFrame:Clear()
 ]],
 }
Sequences[‘ProtAOE’] = {
 StepFunction = [[
 limit = limit or 1
 if step == limit then
 limit = limit % #macros + 1
 step = 1
 else
 step = step % #macros + 1
 end
 ]],
 PreMacro = [[
 /targetenemy [noharm][dead]
 ]],
 “/cast Avenger’s Shield”,
 ‘/cast Consecration’,
 ‘/cast Blessed Hammer,Blessed Hammer’,
 ‘/castsequence reset=6 Judgement’,
 ‘/castsequence reset=90 Blinding Light’,
 ‘/cast Hammer of Justice’,
 ‘/castsequence reset=7 Consecration,Consecration’,
 ‘/cast Blessed Hammer,Blessed Hammer’,
 ‘/cast [@player] Light of the Protector’,
 PostMacro = [[
 /cast Shield of the Righteous
 /cast Avenger’s Shield
 /script UIErrorsFrame:Clear()
 ]],
 }

Try this, I put it in code, fixed a spelling error and put the correct reset timer on blinding light

Just of my own curiosity, though it’s been a while since I read the patch notes, but why is there a need for two separate macros for single/multi target? I thought they combined crusader strike and the other one to make it so you did aoe while consecrate was down. Is it because the AoE one casts Consecrate sooner int he steps, and is there some AoE proc that makes Blessed Hammer castable more often?

just curious ?

[/quote]

I don’t know honestly, I was just trying to help out the OP but I couldn’t test it. Personally I prefer to combine them and lean more towards 1 macro aimed at AE myself.