Hey man, I just wanted to come by as a Protection Paladin main, and one that has made their own macros. Your whole presentation is top notch with the pictures and all, its really helpful to see the macro in picture form instead of just a code you have to import and hope its something worth while you know. Also the legendary is cool and works great because it works in cohesion with the First Avenger talent so you can get a shield buff more often. The talent plus legendary plus the Grand Crusader passive, plus you being Kyrian, man that is alot of shields.
But anyways, now to some critique information, to put it bluntly, you macro is very bloated. The last 4 lines, you dont need them, and to be a more efficient Protection Paladin, you need to have SOTR and WOG separated like instead of Consecration being on ctrl, you can make that WOG. That being said SOTR fires extremely fast whereas WOG takes its time so it can be hard to catch the right HP for it unless you use it with Shining Light procs (also an amazing reason to have WOG on a modifier key). I personally have 2 seperate macros, and both run the same except one is SOTR and one is WOG, also in my WOG variant i have a version that heals on mouseover so thats also a cool idea to think about, especially for smaller stuff like M+ or even raiding.
And my second critique is that you have such an emphasis on Consecration, and even have it on a Mod key. Having something like WOG on that mod key i think would be much more useful. Those few seconds that Consecration didnt fire wont be what killed you, it is only a bit of damage reduction, maybe a little bit of healing, allowing Hammer of Righteous to be an AOE, possibly a slow or anti snare effect depending on your PVE/ PVP talents. Yes that sounds like alot of things it does, but those seconds that it isnt down isnt going to have you killed. It being casted on CD i.e. every 3.8 seconds or faster bc you have such and emphasis on it, that could get you killed. The macro could be casting that instead of something more vital like SOTR, WOG, Avenger’s Shield, Judgment, Hammer of Wrath, Blessed Hammer (If skilled, and if so then that is another reason you dont need to emphasize on consecration so much). I see you have Holy shield as your talent so yes you could argue that your Hammer of the Righteous is then not an AOE, but you know what, you have all of your other spells plus that one to gain HP and after you have at least 3 HP, you can cast SOTR and there is your AOE, and an Effective one at that plus a huge protection buff along with it. So as the macro works through other things consecration can fire a little less urgently i think, my honest opinion based on the things that it said.
Critique List/ Summary
- make the macro more lightweight, get rid of redundancy
- You are missing a few macro conditionals i.e. [combat] for stuff like consecration, Blessed Hammer (if talented), maybe SOTR or WOG too, all of these fire without targets. If you do PVP alot it could be a good idea to leave the combat conditional away but in PVE you probably look like a crazy person running around leaving hammers and consecration everywhere when there is nothing to attack.
- make more emphasis on Avenger’s shield especially with your legendary
- less emphasis on Consecration, aint nobody got time for that to fire on CD when something else is up
- Holy shield is good, but Blessed Hammer is a good contender, you should check it out, especially seeing the way M+ is right now, its like a cast and forget, hits more targets and i think up to 3 time per target per hammer (and if that is right, with 5 guys you could theoretically get 15 hits out from one hammer). AAANNNDDD you can cast it 3 times in a row and use WOG on the move, or you know SOTR if that is what you need, or heck both if Divine Purpose procs.
- Separate SOTR and WOG bc a good tank uses SOTR on CD unless they know that SOTR wont fall off if they use one WOG then they can use WOG outside of Shining Light procs.
Also you can check out my Protection Paladin macros here for ideas maybe. No one is perfect so yeah mine are not also the best, but they work good and i dont have any of the stuff i listed above except redundancy. Sorry for the rant/ critiques, i just wanted to give my 2 cents as a Protection Paladin main. Take care and let me know if you have any questions or what not.