Reverting the code won’t change what Blizzard has done with regards to base spells. GSE doesn’t “do” anything it sends a command to WoW’s macro engine and says please execute. It doesn’t execute a single ability or interpret a single line of macro code. All of that is done by WoW. Unlike Blizzards signed code GSE has to obey the rules that’s Blizzards code doesn’t have to obey.
As a programmer, isn’t all about UID? Revive Pet and Mend Pet now are the same UID. The issue is during the normal macro area, Revive Pet and Mend Pet are 2 separate UIDs but in GSE they are combined as the same UID.
The reason is Mend Pet has 2 ranks, so the first rank (BFA, Legion) do work but Mend Pet rank 2 has a different UID.
Revive Pet ID: 982 (Unchanged from BFA)
Mend Pet Rank 1: 136 (Unchanged from BFA)
Mend Pet Rank 2: 343242
This is where the problem is. Many spells now have 2 ranks, and typically if you use one rank it should not matter but for some reason for some classes it does.
As I mentioned revive/mend pet is not the problem (I was told it was by someone else but @TimothyLuke explained it and they are essentially interchangeable now so it does not matter if GSE changes the revive pet to a mend pet or vice versa since it will still work) . The problem comes from the call pet modifier that tells the macro to only call the pet when it is not dead and that causes GSE to attempt calling the pet while it is dead instead of reviving/mending as it should. The ways to fix this are to either change the order of the macro putting the resurrect pet at the start like this (remember that mend pet=revive pet).
/cast [@pet, dead] Mend Pet; [nopet, nodead] Call Pet 1; [@pet, nodead, nochanneling] Mend Pet
You also need to remember the GCD for spells will make it so if you put that macro in the keypress section it will make the macro stop after it casts that (takes time to cast it and you are unable to cast anything else while doing it). So, put it in the key release section of the gse macro instead to prevent that.
GSE can’t use the UID - only Blizzard Code can use it. It asks WoW to convert the UID to text and then sends the text to WoW’s macro engine to be executed. When I ask it to translate Revive Pet and Mend Pet it returns the same UID depending on the state of your pet.
I levelled a hunter earlier today from 50 to 60 and was using this without issue.
$$/cast [nopet, nodead] Call Pet 1; [@pet, dead] Revive Pet; [@pet, nodead, nochanneling] Mend Pet
The other alternative is to use a variable:
- Create a variable containing the following:
[@pet, dead] Revive Pet;called REVIVE - Use the following line instead
/cast [nopet, nodead] Call Pet 1; ~~REVIVE~~ [@pet, nodead, nochanneling] Mend Pet
This will force the text to be Revive Pet when it goes to WoW’s macro engine irrespective of anything else.
Very odd as they are two different spells. In BFA all spells had 1 rank but in SL many spells have multiple ranks. This is the same issue where GSE thinks Sinister Strike and Mutilate are the same thing when they are not as SS only awards 1 combo point, and Mutilate awards 2 CP.
When it does kick back the UID to you which one does it provide the rank 1 variant or the rank 2 variant.
Which ever one you have as the highest learnt rank.
If i could just use the UID it would be soooooooooo much cleaner.
I bet, I remember before GSE we had to know the UID for every spell.
I wish there was a way to fix this on multiple classes, not just Hunters.
If you are running the latest GSE - there is already a fix to show your specs spells rather than the base spell.
The thing about Base Vs Upgraded using your SS and Mutilate example is that when you /cast Mutilate, WoW’s code is actually casting SS you just dont see it its hidden under the UI. The possibilities that opens is that you can create a macro that works across specs.
I just tried to copy/paste the macro you had just posted in into a larger aio gse macro and was having the same issue as I had with the 1 I tried (breaks everything in the macro and will not even summon the pet I dismissed). Also, it seems to happen when I put it in the keyrelease section as well (I thought I had fixed that before but guess it hadnt saved when I edited it in replacing the click macro I had durring the test bc was still in combat or something). So far the only for sure fix I have found that will work with most of the macros I find here is the /click macro workaround and I am unsure why but for whatever reason gse does not get allong with call pet (or at least not in the keypress or keyrelease sections of the macro and I even tried just
/cast [nopet, nodead] Call Pet 1 without the mend pet or revive on it with same result). I have not tried it in the premacro, sequence, or postmacro sections bc I want it to cast mend pet whenever it is on cooldown and was hoping not to have to add 2-3 seperate entries into the macro when I can add it all to 1 (which I can do even if it requires a /click macro). I even tried updating gse to be sure I was using latest version but still have same problem.
WINNER WINNER thanks to original poster and to you seen a 400 dps increase using this
Is there away to get Barb time up more? is it gear dependent? Im 205 ilvl 4-4.5k sustained dps but barb time on logs is showing
me 78-88% uptime
First off, thank you @Moonsorow for putting in the time and effort to create and upkeep this macro.
I am curious however, how to tweak these to get a better uptime on Barbed Shot. It seems that I am mostly at 1 stack and sometimes get lucky procs to get up to 3 but other than that, no. I have ~21% haste (657) & 22% Crit (420) Im running this at 100ms… Not sure if I should tweak timings or change macro somehow. What are your thoughts? anyone else figure this stuff out?
I just added a /cast barbed Shot to the PreMacro and KeyRelease… but I’ll need to run some parses to see how it does.
lemme know how it does
Which website are u using for this info?
Overall very good! One major problem from this macro is to use Cobra Shot effizienz.
I just try to adjust the macro but didnt get it effectiv using of cobra shot
I have 931 hast and 420 crit
i’m currently running this macro in 14’s and 15’s very nice indeed
What’s the most up to date version of this ? Is it the main one ?