GS/ GSE2.0 7.30 Blood

@John

I have a questions. Besides the addition of Blooddrinker in Tab 2, is there any other difference? I see they structured differently and I’ve tried both. If I remember correctly, I thought Tab 1 fared slightly better in regards to DPS than TAB 2 on a target dummy but in raid I thought Tab 2 fared better.

To be honest I don’t know, personally I only use tab 1, blood drinker version was developed due to user demand, er request, :stuck_out_tongue:

For me it’s a case of if it ain’t broke don’t fix, Tbh the only changes I make are talents and statweights depending on boss, ie in TOS I tank with t19 and dps trinkets, until kiljaden where I swap to t20, tank trinkets and use rune tap, if using crit gear I swap to spectral deflection and blood worms in addition. But the macro is still old faithful tab 1

@John Mets
hi
I really like you macro and it works good but do you have macro keeps the death strike all time active

I’ll assume you are asking is why death strike is in the macros. The purpose of these macros is automation. I’m not sure why you wouldn’t want it in the macros. It still can be fired when/if there is runic power. It’s not like firing off an ability like Blooddrinker, which is only used when needed. Death Strike is our main dps and healing ability and you want to use it often.

Yeah there are many reasons death strike is in there in addition to either spaming extra yourself as needed. It spaces out rune spenders for a more fluid rotation otherwise you would be there on no runes full rp and auto attacking, quite often.

Most importantly as previously stated it’s a main source of damage for a blood dk. Up until recently the class copped bad flak for being bottom tier and squishy, which frankly anyone who has used this macro from legion launch would argue is not the case.

The two big things I notice with dks that seem to be struggling is when they don’t, A, deathstrike or marrowrend enough. B, death and Decay enough.

Despite the many that complain on the forums and want things like rune tap baked into the class and lack of active mitigation, The blood Dk actually is able to have active mitigation 100% of the time, combined with ludicrous self healing, aside from kiljaden I personally don’t need rune tap.

This is all thanks to both marrowrend and Deathstrike. So it’s important to keep deathstrike rolling even when not tanking boss in swap fights, as it not only keeps dps going but means your mitigation is up and ready when taunting boss back, also if you have unlocked your weapon, the overhealing you do increases you total hp. Going from 8 million to 22 million when you pop vamp is real nice.

Looks like I’ve rambled on thanks to the long train ride to work lolz.

Can you make this to where it doesnt use Vampiric or Dancing Rune?

Just remove the /cast lines of those abilities.

Just a heads up, I’ve been testing this on the 7.3 PTR and everything still works fine so updated title to suit, no fear Blood Dks just another day at the office for us.

[quote quote=50167]As proof to this macro, with a slight edit to get DnD down more, I set myself on the dummy with my keyboard on toggle mode at 90ms and walked away… Came back almost 10 minutes later to this. LMAO
Screenshot1
Here is the slightly modified version…

<table class="crayon-table"><tbody><tr class="crayon-row"><td class="crayon-nums " data-settings="show">
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
</td><td class="crayon-code">
<span class="crayon-v">Sequences</span><span class="crayon-sy">[</span><span class="crayon-s">'DK_Blood'</span><span class="crayon-sy">]</span><span class="crayon-h"> </span><span class="crayon-o">=</span><span class="crayon-h"> </span><span class="crayon-sy">{</span>
<span class="crayon-c">-- This Sequence was exported from GSE 2.1.01.</span>
<span class="crayon-h"> </span><span class="crayon-v">Author</span><span class="crayon-o">=</span><span class="crayon-s">"John Metz"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">SpecID</span><span class="crayon-o">=</span><span class="crayon-cn">250</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">Talents</span><span class="crayon-h"> </span><span class="crayon-o">=</span><span class="crayon-h"> </span><span class="crayon-s">"2112132"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-st">Default</span><span class="crayon-o">=</span><span class="crayon-cn">1</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">MacroVersions</span><span class="crayon-h"> </span><span class="crayon-o">=</span><span class="crayon-h"> </span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-sy">[</span><span class="crayon-cn">1</span><span class="crayon-sy">]</span><span class="crayon-h"> </span><span class="crayon-o">=</span><span class="crayon-h"> </span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-v">Trinket2</span><span class="crayon-o">=</span><span class="crayon-r">true</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">StepFunction</span><span class="crayon-h"> </span><span class="crayon-o">=</span><span class="crayon-h"> </span><span class="crayon-s">"Sequential"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">KeyPress</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [combat] Vampiric Blood"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [combat] Dancing Rune Weapon"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [combat] Blood Fury"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">PreMacro</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast Death Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [@player] Death and Decay"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast Blood Boil"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast Marrowrend"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast Blood Boil"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast Heart Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [@player] Death and Decay"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast Consumption"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/castsequence Marrowrend, Marrowrend, Death Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/castsequence Death Strike, Blood Boil, Heart Strike, Heart Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/castsequence Marrowrend, Heart Strike, Blood Boil, Heart Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [@player] Death and Decay"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">PostMacro</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">KeyRelease</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-s">"/targetenemy [noharm][dead]"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">[</span><span class="crayon-cn">2</span><span class="crayon-sy">]</span><span class="crayon-h"> </span><span class="crayon-o">=</span><span class="crayon-h"> </span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-v">Trinket2</span><span class="crayon-o">=</span><span class="crayon-r">true</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">StepFunction</span><span class="crayon-h"> </span><span class="crayon-o">=</span><span class="crayon-h"> </span><span class="crayon-s">"Sequential"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">KeyPress</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [combat] Vampiric Blood"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [combat][no channeling] Dancing Rune Weapon"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [mod:alt] Death Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">PreMacro</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [no channeling] Death Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast blooddrinker"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [@player] Death and Decay"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [no channeling] Marrowrend"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [no channeling] Blood Boil"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [no channeling] Heart Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/castsequence [no channeling] Marrowrend, Marrowrend, Death Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/castsequence [no channeling] Blood Boil, Heart Strike, Heart Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/castsequence [no channeling] Marrowrend, Heart Strike, Blood Boil, Death Strike"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-s">"/cast [no channeling] Consumption"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">PostMacro</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-v">KeyRelease</span><span class="crayon-o">=</span><span class="crayon-sy">{</span>
<span class="crayon-h"> </span><span class="crayon-s">"/targetenemy [noharm][dead]"</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-h"> </span><span class="crayon-sy">}</span><span class="crayon-sy">,</span>
<span class="crayon-sy">}</span>
</td></tr></tbody></table>
[/quote]

When I run this macro I get this error:
Date: 2017-09-09 19:57:20
ID: 3
Error occured in: Global
Count: 1
Message: …\FrameXML\RestrictedExecution.lua line 397:
Call failed: [string “local step = self:GetAttribute(‘step’)…”] line 11:
attempt to index global ‘macros’ (a nil value)
Debug:
[C]: ?
[C]: ?
…\FrameXML\RestrictedExecution.lua:397:
…\FrameXML\RestrictedExecution.lua:390
(tail call): ?
(tail call): ?
…\FrameXML\SecureHandlers.lua:283:
…\FrameXML\SecureHandlers.lua:277
(tail call): ?
[C]: Click()
…\FrameXML\ChatFrame.lua:1508: ?()
…\FrameXML\ChatFrame.lua:4492: ChatEdit_ParseText()
…\FrameXML\ChatFrame.lua:4180: ChatEdit_SendText()
…\FrameXML\ChatFrame.lua:2759:
…\FrameXML\ChatFrame.lua:2752
[C]: UseAction()
…\FrameXML\SecureTemplates.lua:346: handler()
…\FrameXML\SecureTemplates.lua:619:
…\FrameXML\SecureTemplates.lua:567
[C]: ?
…\FrameXML\SecureHandlers.lua:264:
…\FrameXML\SecureHandlers.lua:261
[C]: ?
…\FrameXML\SecureHandlers.lua:294:
…\FrameXML\SecureHandlers.lua:277
(tail call): ?
Locals:

AddOns:
Swatter, v7.0.5 (<%codename%>)
AtlasLoot, vv8.06.01
AtlasLootBurningCrusade, vv8.06.01
AtlasLootCataclysm, vv8.06.01
AtlasLootClassic, vv8.06.01
AtlasLootLegion, vv8.06.01
AtlasLootMistsofPandaria, vv8.06.01
AtlasLootWarlordsofDraenor, vv8.06.01
AtlasLootWrathoftheLichKing, vv8.06.01
Auctionator, v4.0.19
Babylonian, v5.1.DEV.332(/embedded)
BagBrother, v
Bagnon, v7.3.1
Bartender4, v4.7.10
Configator, v5.1.DEV.406(/embedded)
Gatherer, v7.0.5
GSE, v2107
MoveAnything, v16.2.2
Recount, vv7.3.0b
SlideBar, v7.0.5 (<%codename%>)
TradeSkillMaster, vv3.6.35
TradeSkillMasterAccounting, vv3.0.20
TradeSkillMasterAppHelper, vv3.0.4
TradeSkillMasterAuctionDB, vv3.1.18
TradeSkillMasterAuctioning, vv3.0.16
TradeSkillMasterCrafting, vv3.2.5
TradeSkillMasterDestroying, vv3.1.7
TradeSkillMasterMailing, vv3.0.18
TradeSkillMasterShopping, vv3.4.7
TradeSkillMasterVendoring, vv3.0.7
TradeSkillMasterWarehousing, vv3.0.6
WeakAuras, v2.4.21
WorldQuestTracker, v
ZPerl, v5.4.4
ZPerlArcaneBar, v
ZPerlParty, v
ZPerlPartyPet, v
ZPerlPlayer, v
ZPerlPlayerBuffs, v
ZPerlPlayerPet, v
ZPerlRaidAdmin, v
ZPerlRaidFrames, v
ZPerlRaidHelper, v
ZPerlRaidPets, v
ZPerlTarget, v
ZPerlTargetTarget, v
BlizRuntimeLib_enUS v7.3.0.70300 <none>
(ck=51c)

In fact I get errors when doing pretty much anything with this addon. At a complete loss.

This may come as a shock but John actually cant debug your problem as you have a problem with GSE itself not his macro. So posting this here will normally piss John off and do nothing to help you get a solution to your problem.

Let me save a lot of John’s time:

If you have a problem with GSE - go here: github.com/TimothyLuke/GnomeSequencer-Enhanced Search through what has already been asked and answered and if you cant find a solution there raise an issue. From there the process is very simple. I will tell you to turn off every other mod apart from GSE and then tell me what error you have. I will tehn tell you to delete the GSE.lua file and restart and do you have the same problem. When you dont I will tell you where your problem was - your old GSE.lua file.

The only reason I saw this was a link from Discord. I dont read every post on every class.

Thx john. works great for my LFR needs.

@John Mets,

Howdy, I used your script for my DK blood spec and wanted tell you that your script is best ever smooth fluid during the tanking in heroics dungeons. Totally satisfied!

Glad People are still pleased with this Macro that has changed very little since Legion Pre patch.

Below is a slight Tweak I am still gathering data on before I bump it to OP.
the intent here is to improve Boneshield stack recovery a little, as I started to notice certain gear setups I run sometimes had issues where if stacks dropped off due to mechanics or were depleted very quickly I had to manually mash Marrowrend to get stacks back up :frowning:

Sequences['DKBLOOD'] = {
-- This Sequence was exported from GSE 2.2.02.
  Author="John Metz",
  SpecID=250,
  Talents = "2112132",
  Default=1,
  MacroVersions = {
    [1] = {
      StepFunction = "Sequential",
      KeyPress={
        "/cast [combat] Vampiric Blood",
        "/cast [combat] Dancing Rune Weapon",
        "/cast [mod:alt] Death Strike",
      },
      PreMacro={
      },
        "/cast Marrowrend",
        "/cast Death Strike",
        "/cast [@player] Death and Decay",
        "/cast Blood Boil",
        "/cast Marrowrend",
        "/cast Blood Boil",
        "/cast Heart Strike",
        "/cast [@player] Death and Decay",
        "/cast Consumption",
        "/cast [@player] Death and Decay",
        "/castsequence Marrowrend, Marrowrend, Death Strike",
        "/castsequence Death Strike, Blood Boil, Heart Strike, Heart Strike",
        "/castsequence Marrowrend, Heart Strike, Blood Boil, Heart Strike",
      PostMacro={
      },
      KeyRelease={
        "/targetenemy [noharm][dead]",
      },
    },
  },
}

Okay, I am going test it right now running Heroic dungeon with your new tweak script. I’ll keep you post after run the heroic right now.

updated I noticed tweak script is much better uptime Boneshield stacks and quickly DnD than current DKBLOOD.

Macro inputs into addon with no issue, but icon is solid and will not allow me to drag to bar, am I missing something? Also I am new to this , but all other macros ive used so far have worked.

@Cesar Lawton when you are at the macro selection page there is a button with icon in the name select this macro and then click that button until it has a question mark on it then you will be able to move it

Thank you, I will try it when I get home tonight!

@johnmetz
really enjoying this macro

John, I found that the spam speed may be the issue with the stacks not refreshing. It may be something that can’t be helped due to mechanics. Like you, I just settled to having a second modifier to refresh. The other problem I found was with runic power regen. I’m sitting at about 27% haste depending on gear. I found runic regen was not keeping pace with ability needs. The problem for me was button spam and global cool down. Originally, I was running this with a delay of 90ms, which I found too fast. Once I shifted down to 140ms, I found I had less of a problem. There are still a few dead spots but nothing I couldn’t get through. FYI fr those that may ask, I use synapse.

[quote quote=55159]John, I found that the spam speed may be the issue with the stacks not refreshing. It may be something that can’t be helped due to mechanics. Like you, I just settled to having a second modifier to refresh. The other problem I found was with runic power regen. I’m sitting at about 27% haste depending on gear. I found runic regen was not keeping pace with ability needs. The problem for me was button spam and global cool down. Originally, I was running this with a delay of 90ms, which I found too fast. Once I shifted down to 140ms, I found I had less of a problem. There are still a few dead spots but nothing I couldn’t get through. FYI fr those that may ask, I use synapse.
[/quote]

Quite possibly. the more I’ve worked on these macros the more variables I come across that I cant account for.
macro speed is an obvious factor, I personally have it set high because I play on an NA server though I live in Aus, so the 210ms latency offsets the speed. this is also why I often don’t mention what speed to set things at as all characters are different.

As far as RP generation goes I don’t have this issue this is probably due to my characters gear set up Leggos stat weights etc. this is where I can have the most issues with variables. as what often works perfectly for me may suck for others. with my character I have RP to spare and why I included the deathstrike modifier to burn excess RP