Prot/Gladiator GS Macro

Give this a try and let me know what you think, My DPS went up significantly

Sequences["WarProtST"] = { 
PreMacro = [[
/targetenemy [noharm][dead]
/cast charge
]],
	StepFunction = [[
		stepa = "132432653246"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
	]],

	-- Macro 1
	[[
/run("Executing macro 1!")
/cast Shield Charge
	]],
	
	-- Macro 2
	[[
/run("Executing macro 2!")
/cast Heroic Strike
	]],
	
	-- Macro 3
	[[
/run("Executing macro 3!")
/cast Shield Slam
	]],

	-- Macro 4
	[[
/run("Executing macro 4!")
/cast Revenge
	]],
    -- Macro 5
	[[
/run("Executing macro 5!")
/cast Execute
	]],
    -- Macro 6
	[[
/run("Executing macro 6!")
/cast Devastate
	]],
}

Added Hamstring

Sequences["WarProtST"] = { 
PreMacro = [[
/targetenemy [noharm][dead]
/cast charge
/cast Bloodbath
]],
	StepFunction = [[
		stepa = "132432653246"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
	]],

	-- Macro 1
	[[
/run("Executing macro 1!")
/cast Shield Charge
	]],
	
	-- Macro 2
	[[
/run("Executing macro 2!")
/cast Heroic Strike
	]],
	
	-- Macro 3
	[[
/run("Executing macro 3!")
/cast Shield Slam
	]],

	-- Macro 4
	[[
/run("Executing macro 4!")
/cast Revenge
	]],
    -- Macro 5
	[[
/run("Executing macro 5!")
/cast Execute
	]],
    -- Macro 6
	[[
/run("Executing macro 6!")
/cast Devastate
	]],
	PostMacro = [[
/cast Hamstring
/run UIErrorsFrame:Clear()
]],
}

Verry nice macro dude! thumbs up for you

Oh, My talents are 2112223

Nice macro

Thanks for the macro, can you maybe explain the stepfunction?

Thank you for this one, i have been using it in pvp for and its working beautifully.

This is quoted from starcub:

stepa – string containing steps in the sequence to be executed
“12213142111” – is the actual sequence to be executed
limit – is the rotation length or the total number of steps in the sequence (automatically calculated from stepa — no user editing required)
stepc – is the step counter (used to dereference the step in the string)

With this macro i do about 23k dps on Butcher hc
Witout macro i do about 29k dps on same boss
With my macro i do about 33k dps on same boss
My ilvl is 670

here is my macro :

Sequences[‘GLA’] = {
PreMacro = [[
/targetenemy [noharm][dead]
-/cast [combat] Berserker Rage
/cast [combat] Blood Fury
/cast [combat] Berserker Rage
/cast [combat] Bloodbath
/cast [combat] Shield Charge
/cast Heroic Strike
]],
‘/cast !Shield Slam’,
‘/cast !Execute’,
‘/cast Devastate’,
‘/cast !Revenge’,
‘/cast Shield Slam’,
‘/cast [mod:alt] Berserker Rage’,
‘/cast [combat] Dragon Roar’,
‘/cast Shield Slam’,
‘/cast !Revenge’,
‘/cast Devastate’,
‘/cast Storm Bolt’,
‘/cast Heroic Strike’,
‘/cast [combat] Dragon Roar’,
‘/cast !Revenge’,
‘/cast !Shield Slam’,
‘/cast victory rush’,
‘/cast Devastate’,
PostMacro = [[
/startattack
/use [combat]13
/use [combat]14
/cast Shield Slam
]],
}

This isnt a macro to compare to your own, the beauty of this macro is all you have to do is change the step function to the rotation you want, this is a sequenced macro. It doesn’t have to be 132432653246 you can place the rotation you want with it. Your macro will go 12345678, this one will go in any order you assign to it.

I tested your macro and my gear is at 620 I’m doing 2k more with the one I posted and i’m not using my cd’s . I also see that your macro isn’t proctoring sword and board and ultimatum.

Well i do understand your point, not saying mine is better BUT at my ilvl should i choose to use a macro (i dont) everything procs also ultimatum and sword & board, and it does a lot more damage than the one you posted, Tested it again today for full 30 min on dummy (garrison 3 targets) result: Mine 5.3k+ unbuffed. I´m glad you wanna help peeps perform better, so do i… not compeeting with you mate…

Well the rotation order is Important yes, but you have way to few Heroic Strikes in there, for max. dps output you have to spamm it much more under SC and over 80% rage. You dont need the beauty of changing the rotation, we all know the rotation inside out and no macro can be written to do exactly that, with my macro i get to spamm between 2-4 Shield Slam under Shield Charge proc and up to 4 Heroic Stike, that´s where the dps increase is… but hey just wanna help out !

[quote quote=21716]

<div class=“d4p-bbt-quote-title”>Todd Livengood wrote:</div>I tested your macro and my gear is at 620 I’m doing 2k more with the one I posted and i’m not using my cd’s . I also see that your macro isn’t proctoring sword and board and ultimatum.
Well i do understand your point, not saying mine is better BUT at my ilvl should i choose to use a macro (i dont) everything procs also ultimatum and sword & board, and it does a lot more damage than the one you posted, Tested it again today for full 30 min on dummy (garrison 3 targets) result: Mine 5.3k+ unbuffed. I´m glad you wanna help peeps perform better, so do i.. not compeeting with you mate.. [/quote]

I fully agree, I’m all about helping peeps to help increase the max dam/dps output. But my tests are way different. I tested it again and jumped 5k dps over the one you posted I also timed the damage to hit 1mil. I would like to agree with you but its just not coming out the same on my end.

We need people on here to test them out and posts their results.

Hey i have a question what is the executing macro 1,2,3,4,5,6 :slight_smile:

[quote quote=21546]Give this a try and let me know what you think, My DPS went up significantly

Sequences["WarProtST"] = { 
PreMacro = [[
/targetenemy [noharm][dead]
/cast charge
]],
	StepFunction = [[
		stepa = "132432653246"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
	]],

	-- Macro 1
	[[
/run("Executing macro 1!")
/cast Shield Charge
	]],
	
	-- Macro 2
	[[
/run("Executing macro 2!")
/cast Heroic Strike
	]],
	
	-- Macro 3
	[[
/run("Executing macro 3!")
/cast Shield Slam
	]],

	-- Macro 4
	[[
/run("Executing macro 4!")
/cast Revenge
	]],
    -- Macro 5
	[[
/run("Executing macro 5!")
/cast Execute
	]],
    -- Macro 6
	[[
/run("Executing macro 6!")
/cast Devastate
	]],
}
```[/quote]
This macro gives me amazing DPS but its making me rage starved anyway to fix that?

[quote quote=22108]

<div class=“d4p-bbt-quote-title”>Todd Livengood wrote:</div>Give this a try and let me know what you think, My DPS went up significantly
Sequences["WarProtST"] = { 
PreMacro = [[
/targetenemy [noharm][dead]
/cast charge
]],
	StepFunction = [[
		stepa = "132432653246"

		limit = string.len(stepa) or 1
		if stepc == nil then
			stepc = 1
		end
		if stepc >= limit then
			stepc = 1
		else
			stepc = stepc + 1
		end
		step = tonumber(strsub (stepa, stepc, stepc))
	]],

	-- Macro 1
	[[
/run("Executing macro 1!")
/cast Shield Charge
	]],
	
	-- Macro 2
	[[
/run("Executing macro 2!")
/cast Heroic Strike
	]],
	
	-- Macro 3
	[[
/run("Executing macro 3!")
/cast Shield Slam
	]],

	-- Macro 4
	[[
/run("Executing macro 4!")
/cast Revenge
	]],
    -- Macro 5
	[[
/run("Executing macro 5!")
/cast Execute
	]],
    -- Macro 6
	[[
/run("Executing macro 6!")
/cast Devastate
	]],
}
```</blockquote>This macro gives me amazing DPS but its making me rage starved anyway to fix that?
[/quote]


Use Unyielding strikes
Sequences['GWSTT'] = { 
PreMacro = [[
/cast [combat] Berserker Rage
/cast [combat] Blood Fury
/cast [combat] Bloodbath
/cast [combat] Demoralizing Shout
/castsequence reset=10 Shield Charge,heroic strike
/cast heroic strike
]],
	'/cast Shield Slam',	
	'/cast Revenge',
	'/cast Devastate',
PostMacro = [[
/startattack
/use [combat]13
/use [combat]14
]],
}

Seem to have more dps with this

$1::
SetKeyDelay 70,100
#HotkeyInterval 9000
  While GetKeyState("1","P")
    Send, {1}
	Sleep  -1
Return

I use this script code to spam 1

[quote quote=21689]With this macro i do about 23k dps on Butcher hc Witout macro i do about 29k dps on same boss With my macro i do about 33k dps on same boss My ilvl is 670
here is my macro :
Sequences[‘GLA’] = { PreMacro = [[ /targetenemy [noharm][dead] -/cast [combat] Berserker Rage /cast [combat] Blood Fury /cast [combat] Berserker Rage /cast [combat] Bloodbath /cast [combat] Shield Charge /cast Heroic Strike ]], ‘/cast !Shield Slam’, ‘/cast !Execute’, ‘/cast Devastate’, ‘/cast !Revenge’, ‘/cast Shield Slam’, ‘/cast [mod:alt] Berserker Rage’, ‘/cast [combat] Dragon Roar’, ‘/cast Shield Slam’, ‘/cast !Revenge’, ‘/cast Devastate’, ‘/cast Storm Bolt’, ‘/cast Heroic Strike’, ‘/cast [combat] Dragon Roar’, ‘/cast !Revenge’, ‘/cast !Shield Slam’, ‘/cast victory rush’, ‘/cast Devastate’, PostMacro = [[ /startattack /use [combat]13 /use [combat]14 /cast Shield Slam ]], }
[/quote]
Need to post like this. But don’t use it anyways bc it breaks the whole seq file.

Sequences[‘GLA’] = {
PreMacro = [[
/targetenemy [noharm][dead]
-/cast [combat] Berserker Rage
/cast [combat] Blood Fury
/cast [combat] Berserker Rage
/cast [combat] Bloodbath
/cast [combat] Shield Charge
/cast Heroic Strike
]],
‘/cast !Shield Slam’,
‘/cast !Execute’,
‘/cast Devastate’,
‘/cast !Revenge’,
‘/cast Shield Slam’,
‘/cast [mod:alt] Berserker Rage’,
‘/cast [combat] Dragon Roar’,
‘/cast Shield Slam’,
‘/cast !Revenge’,
‘/cast Devastate’,
‘/cast Storm Bolt’,
‘/cast Heroic Strike’,
‘/cast [combat] Dragon Roar’,
‘/cast !Revenge’,
‘/cast !Shield Slam’,
‘/cast victory rush’,
‘/cast Devastate’,
PostMacro = [[
/startattack
/use [combat]13
/use [combat]14
/cast Shield Slam
]],
}