My answer to this question every time it appears is when Blizzard releases a 7.3.5 server I will release a 7.3.5 version of GSE.
Hey Tim, there is an issue in 2.6.16, that I cannot save any changes in new macros loaded from this server.
Edit//
ok its weird. Its something in this code I cannot save:
/targetenemy [noharm][dead]
/castsequence [nochanneling] reset=target/combat Agony, Corruption, Unstable Affliction, Siphon Life, null
/cast [mod:alt] Malefic Rapture
/cast [mod:shift, nochanneling] Dark Soul: Misery
Ditto for me it does not make me modify macros by error translator api etc.
This Line Here: /cast [mod:shift, nochanneling] Dark Soul: Misery
the : was causing the updated code for getting Base Spells to break.
He m8!
I got the error also wen i want to copy a /castsequence lineâŠ
I think the error comes from , null in the macroâŠ
Message: Interface\AddOns\GSE\API\Translator.lua:726: Usage: FindBaseSpellNameByID(spellID)
Time: Mon Oct 19 14:04:33 2020
Count: 5
Stack: Interface\AddOns\GSE\API\Translator.lua:726: Usage: FindBaseSpellNameByID(spellID)
[string â=(tail call)â]: ?
[string â=[C]â]: in function FindBaseSpellByID' [string "@Interface\AddOns\GSE\API\Translator.lua"]:726: in function
GetSpellIdâ
[string â@Interface\AddOns\GSE\API\Translator.luaâ]:254: in function TranslateSpell' [string "@Interface\AddOns\GSE\API\Translator.lua"]:164: in function
TranslateStringâ
[string â@Interface\AddOns\GSE\API\Translator.luaâ]:16: in function TranslateSequence' [string "@Interface\AddOns\GSE_GUI\GUIFunctions.lua"]:127: in function
GUIUpdateSequenceDefinitionâ
[string â@Interface\AddOns\GSE_GUI\Editor.luaâ]:247: in function <Interface\AddOns\GSE_GUI\Editor.lua:231>
[string â=[C]â]: ?
[string â@Interface\AddOns\AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0.luaâ]:72: in function <âŠddOns\AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0.lua:70>
[string â@Interface\AddOns\AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0.luaâ]:306: in function `Fireâ
[string â@Interface\AddOns\AddOnSkins\Libs\Ace3\AceGUI-3.0\widgets\AceGUIWidget-Button.luaâ]:22: in function <âŠLibs\Ace3\AceGUI-3.0\widgets\AceGUIWidget-Button.lua:19>
This is an example of how to help me fix your issues. Instead of posting âI had a problem at line xxxxxxâ without any context, this actually gave me somewhere to look to replicate the problem. Dont get me wrong the error at line x is important but its only half the story and often times all i can respond with is âyes an error occuredâ.
What is not realised is that of the 500k lines of code that makes up GSE a lot of it is continually reused. All the translating spell stuff for exaple is used when saving, its used when showing you the information in the editor, its used when your macro is running. the context means i know where in the 500k lines to look.
I do a series of tests each build. You can see the results starting here: Travis CI - Test and Deploy Your Code with Confidence These tests check that I can save and update and that the change gets past all the known gotchas. I dont push out builds as releases for you guys to test. I push a release when I am confident its not going to break things for you and it will work like before. The more useful, troubleshooting information you can give me the faster I can solve the problem. This is where Issues · TimothyLuke/GSE-Advanced-Macro-Compiler · GitHub is so important. This is a place to discuss GSE problems and gather all the information into one place and keeps this site clear to discuss things that matter like macros.
BTW the 2.6.17 build should fix the no saving for those of you who experience it.
Iâll try the new update, thx, but as far as I can tell, I tried it before you posted your answer, it seemed like the only thing I couldnât save was the line where it was null. So I think it was a null expression.
@nicki-kra WHen BFA started we manually kept a list of basespells and overrides. When this expansion hit while trying to find a better way of translating i came across a function that gave the base for an override. The problem occured when trying to save the name of a spell you dont know or one that had some weird characters in it. As you dont know ânullâ it couldnt find the base spell for it
This change was the underlying cause: Investigate the alternatives to Base Spells and Spell Link over Spell Info · Issue #724 · TimothyLuke/GSE-Advanced-Macro-Compiler · GitHub
null, spells you didnt know (in my case Dark Soul: Misery as I only have a level 35 lock) or even the monk spell âStorm, Earth, Fireâ would all break it - as I didnât use any of those it didnât come up in my testing
Thanks for your very quickly reaction and fix, you are the best man
So resuming the problem was --> : <-- that was not calling the spell ids ?
Jeez, so much code to redo the tests right?
Anyways, your last update fixed it.
Thanks
quick question, Iâm adding some Stormstrike lines to my macro. I save my work and when I go back into edit. My Stormstrikes are converted to Primal Strike. Any suggestions?
Itâs supposed to do that. Primal strike is the base spell for Stormstrikes. If you put /cast primal strike into your macro, it will fire storm strikes if that has replaced primal strike because of a talent it proc etc. however if you put stormstrikes and donât have the talent or proc it will either do nothing if itâs a cast line, or lock your macro if itâs in a castsequence line.
Shadow priests have a case where they explicitly need to cast the updated version of a spell and only in a unique circumstance so they can prefix that line with $$
Hello, just a minor problem, after loading the macro for BM Hunter, it got the right spell to editor (Cobra Shot), but after saving and reopening, Cobra was renamed Steady Shot.
No that is working as expected. GSE stores the BASE SPELL. Changing Talents, Procs and changing specs change the base spell into something. The base spell is Steady Shot but when you change to Beast Master it changes to Cobra Shot. Itâs the same with Priests. The base spell is Flash Heal and when you swap to shadow it changes to Shadowmend. putting /cast Steady Shot in your macro will in fact cast Cobra Shot if you are in BM same as /cast Flash Heal will cast Shadowmend if you are shadow specâd
In the past, I had a list of what changed into what and it was hit and miss. GSE now uses WoWâs internal list of what the base spells are and what the updated ones are.
You are right, in logs there is nicely see a Cobra Shot was firing
When I saw it happening for spells I wasnât expecting - I freaked initially.
There is the ability to put $$/cast xxxxxx
the $$ at the start of the line means use this explicitly listed version. This is handy again for the Shadow priests who need to cast Void Bolt while channeling a specific spell.
Yup, that was a very awesome addition to your GSE